JoaoJandre commented on PR #8362:
URL: https://github.com/apache/cloudstack/pull/8362#issuecomment-1924266633
@shwstppr from your description, it seems like you're proposing something
that already exists, we already have limits for all resources you listed (and a
few more) on an account/domain scope, I feel like I'm missing something here,
could you maybe describe a little further what you're proposing?
Also, about this:
> Adds option to list disk offering with suitability flag for a virtual
machine. A new parameter named virtualmachineid has been added to the
listDiskOfferings API which when passed returns suitableforvirtualmachine param
in the response.
To me this looks like an unrelated change, this PR is already big, so adding
more context will make it a little too complex for reviewing. It would be
better to separate different changes in different PRs so that we can properly
review the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
