JoaoJandre commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1930349553
> > @rohityadavcloud @DaanHoogland @weizhouapache @shwstppr @JoaoJandre > > What do you guys think about a little freeze between today and tomorrow, to re-run the CI and manual tests (just for sake) and finally merge this PR? This PR touches a lot of files and might conflict with the merge of almost any other PR, which might lead us to an endless cycle here (this PR is already 1 year old 🧓). > > 1 year old is still young 😃 > > let's wait for the testing results. If all are ok, I am ok with merging it. > > @JoaoJandre Do you have a script or command to update the Java files to work with 2.x? We will face a lot of conflicts or compilation issues when merge forward 4.18/4.19 to main. @weizhouapache The following script should help, it will fix any import issues, as well as try to normalize the logger name from `s_logger` to `LOGGER` or `logger` (depending if the logger should be static or not), people might still have some issues with loggers created under different names, but that should be an easy manual fix. Here's the script: - https://pastebin.com/GzMP3PCA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
