DaanHoogland commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1487467214
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
I too would like to see a test description.
I agree that preventing a call to the server is good, but a working solution
is as well ;)
I could live with a comment in the code that explains the better solution
and why it was not implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
