GaOrtiga commented on code in PR #8306:
URL: https://github.com/apache/cloudstack/pull/8306#discussion_r1491278333
##########
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java:
##########
@@ -443,9 +451,14 @@ public List<StoragePoolVO> findDisabledPoolsByScope(long
dcId, Long podId, Long
@Override
public List<StoragePoolVO> findLocalStoragePoolsByTags(long dcId, long
podId, Long clusterId, String[] tags, boolean validateTagRule) {
+ return findLocalStoragePoolsByTags(dcId, podId, clusterId, tags,
validateTagRule, null);
+ }
+
+ @Override
+ public List<StoragePoolVO> findLocalStoragePoolsByTags(long dcId, long
podId, Long clusterId, String[] tags, boolean validateTagRule, String keyword) {
List<StoragePoolVO> storagePools = null;
if (tags == null || tags.length == 0) {
Review Comment:
@GutoVeronezi @DaanHoogland
Since no changes have been made to this line, I believe the proposed
suggestion would not align with the scope of this PR.
It would be more appropriate to address this in a separate PR focused on
refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
