sureshanaparti commented on code in PR #8671:
URL: https://github.com/apache/cloudstack/pull/8671#discussion_r1492522799
##########
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##########
@@ -2650,7 +2650,8 @@ private UserAccount getUserAccount(String username,
String password, Long domain
continue;
}
}
- if (secretCode != null &&
!authenticator.getName().equals("oauth2")) {
+ if ((secretCode != null &&
!authenticator.getName().equals("oauth2"))
+ || (secretCode == null &&
authenticator.getName().equals("oauth2"))) {
Review Comment:
can replace string "_oauth2_" with relevant constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
