weizhouapache commented on PR #8385: URL: https://github.com/apache/cloudstack/pull/8385#issuecomment-1952078221
> Tested these changes. I couldn't find any difference in performance for these changes. I followed these steps: > > 1. Setup 2 envs (with and without this patch) > 2. Create a VPC with redundant offering > 3. Add 10 networks and launch 1 VM in each > 4. Restarted VPC with cleanup > 5. Check the difference in created, removed in async_job table for VPCRestartCmd @vishesh92 it is probably because our database is too small. if the platforms have been running for many years (for example, more than 5), it could make big difference. considering this is an optimization, it looks there is no regression (in manual and smoke tests), can we say it is good to merge ? @vishesh92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
