weizhouapache commented on PR #8643: URL: https://github.com/apache/cloudstack/pull/8643#issuecomment-1953951581
> > > > @DaanHoogland maybe better to add the column to `volume_view` > > > > > > > > > makes sense but the field doesn't exist. I'll refresh my sql-fu to get it in. > > > > > > with your PR #8647 , you need to add a line to engine/schema/src/main/resources/META-INF/db/views/cloud.volume_view.sql > > ``` > > `volumes`.`encrypt_format` AS `encrypt_format`, > > ``` > > > > > > > > > > > > > > > > > > > > > > > > then add the field in `VolumeJoinVO` > > I thought you meant a field `isEncrypted`. this is simpler, thanks. if need, you can add a method `isEncrypted` in `VolumeJoinVO` :smiley: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
