weizhouapache commented on PR #8735: URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-1975991149
> > what if the volume is removed manually after snapshot policy is created ? > > it may be better to add constraint to the table `snapshot_policy`, to prevent the volume to be removed manually, if there are snapshot policies linked to it. > > I agree, but this code is still good and anybody could use it in older versions (backport it) I don't think it hurts in any way even with the constraint. > > If that works a cascading delete would be usefull in this case ;) @DaanHoogland yes, with PR, the mgmt server will be started without any issue , even if volume is removed manually from database. @rohityadavcloud code lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
