GaOrtiga commented on code in PR #8801:
URL: https://github.com/apache/cloudstack/pull/8801#discussion_r1537551760
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java:
##########
@@ -785,32 +768,32 @@ protected String getKubernetesClusterNodeNamePrefix() {
protected KubernetesClusterVO updateKubernetesClusterEntry(final Long
cores, final Long memory, final Long size,
final Long serviceOfferingId, final Boolean autoscaleEnabled,
final Long minSize, final Long maxSize) {
- return Transaction.execute(new
TransactionCallback<KubernetesClusterVO>() {
- @Override
- public KubernetesClusterVO doInTransaction(TransactionStatus
status) {
- KubernetesClusterVO updatedCluster =
kubernetesClusterDao.findById(kubernetesCluster.getId());
- if (cores != null) {
- updatedCluster.setCores(cores);
- }
- if (memory != null) {
- updatedCluster.setMemory(memory);
- }
- if (size != null) {
- updatedCluster.setNodeCount(size);
- }
- if (serviceOfferingId != null) {
- updatedCluster.setServiceOfferingId(serviceOfferingId);
- }
- if (autoscaleEnabled != null) {
-
updatedCluster.setAutoscalingEnabled(autoscaleEnabled.booleanValue());
- }
- updatedCluster.setMinSize(minSize);
- updatedCluster.setMaxSize(maxSize);
- return kubernetesClusterDao.persist(updatedCluster);
+ return Transaction.execute((TransactionCallback<KubernetesClusterVO>)
status -> {
+ KubernetesClusterVO updatedCluster =
kubernetesClusterDao.createForUpdate(kubernetesCluster.getId());
+
+ if (cores != null) {
+ updatedCluster.setCores(cores);
+ }
+ if (memory != null) {
+ updatedCluster.setMemory(memory);
+ }
+ if (size != null) {
+ updatedCluster.setNodeCount(size);
}
+ if (serviceOfferingId != null) {
+ updatedCluster.setServiceOfferingId(serviceOfferingId);
+ }
+ if (autoscaleEnabled != null) {
+
updatedCluster.setAutoscalingEnabled(autoscaleEnabled.booleanValue());
+ }
+ updatedCluster.setMinSize(minSize);
+ updatedCluster.setMaxSize(maxSize);
+ return kubernetesClusterDao.persist(updatedCluster);
});
}
+
Review Comment:
@FelipeM525 Can you remove these extra lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
