DaanHoogland commented on issue #8745: URL: https://github.com/apache/cloudstack/issues/8745#issuecomment-2039702438
just reviewed both solutions (@JoaoJandre ) and both seem to do the job #8881 does it by overloading the call to create the LB commands #8765 does it by checking which list to load from the DB If I understand correctly this creates the list multiple times in #8765, while in #8881 it is created only once. I see no problem with either code but I think Wei has a point and we should go with the overloading solution. Note that this is purely from a code analysis point of view. I have not had time to test either yet but have started building the envs to check them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
