borisstoyanov commented on PR #8916: URL: https://github.com/apache/cloudstack/pull/8916#issuecomment-2059051822
> > LGTM, manually tested > > @vishesh92 @borisstoyanov could you be more clear about the tests you have done? I've set the GS to 10 seconds and verified the job executes accordingly, then did some boundary testing and verified the schedule is disabled with setting value of 0 and negative. ``` 13:00:22,874 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-2a6bc5af) (logid:7041d095) Started resource counters recalculation periodic task. 13:00:24,689 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-2a6bc5af) (logid:7041d095) Finished resource counters recalculation periodic task. 13:00:32,921 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-2239d7a9) (logid:74570f70) Started resource counters recalculation periodic task. 13:00:33,395 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-2239d7a9) (logid:74570f70) Finished resource counters recalculation periodic task. 13:00:42,926 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-92e12d7e) (logid:ad039d2b) Started resource counters recalculation periodic task. 13:00:43,431 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-92e12d7e) (logid:ad039d2b) Finished resource counters recalculation periodic task. 13:00:52,985 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-bc300f8a) (logid:01944963) Started resource counters recalculation periodic task. 13:00:53,732 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-bc300f8a) (logid:01944963) Finished resource counters recalculation periodic task. 13:01:02,958 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-9e5a7d0d) (logid:54c8cf4b) Started resource counters recalculation periodic task. 13:01:03,492 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-9e5a7d0d) (logid:54c8cf4b) Finished resource counters recalculation periodic task. 13:01:12,975 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-cc951ced) (logid:ef37a93f) Started resource counters recalculation periodic task. 13:01:13,509 INFO [c.c.r.ResourceLimitManagerImpl] (ResourceCountChecker-1:ctx-cc951ced) (logid:ef37a93f) Finished resource counters recalculation periodic task. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
