weizhouapache commented on issue #8912:
URL: https://github.com/apache/cloudstack/issues/8912#issuecomment-2060474463

   @levindecaro 
   I did a quick test on the changes on VM XML definition
   ```
   -      <entry name='product'>CloudStack KVM Hypervisor</entry>
   +      <entry name='vendor'>CloudStack KVM Hypervisor</entry>
   ```
   
   what I found are
   - `virsh dumpxml` shows there is no `vendor` after the change
   
   ```
     <sysinfo type='smbios'>
       <system>
         <entry name='manufacturer'>Apache Software Foundation</entry>
         <entry name='uuid'>4d37861f-9be8-472b-af8e-8e896b9ed4b7</entry>
       </system>
     </sysinfo>
   ```
   
   - `dmidecode` command shows the product name is changed to `KVM` instead of 
`CloudStack KVM Hypervisor`
   
   ```
    Handle 0x0100, DMI type 1, 27 bytes
    System Information
        Manufacturer: Apache Software Foundation
   -    Product Name: CloudStack KVM Hypervisor
   +    Product Name: KVM
        Version: RHEL 7.6.0 PC (i440FX + PIIX, 1996)
        Serial Number: Not Specified
        UUID: 4D37861F-9BE8-472B-AF8E-8E896B9ED4B7
   ```
   
   As I know, this will break the datasource check on CloudStack in cloud-init, 
which checks the product name in `dmidecode` output.
   
   ```
   dscheck_CloudStack() {
       is_container && return ${DS_NOT_FOUND}
       dmi_product_name_matches "CloudStack*" && return $DS_FOUND
       return $DS_NOT_FOUND
   }
   ```
   
https://github.com/canonical/cloud-init/blob/5d587ecd0dfd952ad17caa123de9d954c3ceb07d/tools/ds-identify#L786-L790
   of course you can skip ds-identify by
   ```
   echo "policy: enabled" >  /etc/cloud/ds-identify.cfg
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to