lucas-a-martins commented on PR #8603:
URL: https://github.com/apache/cloudstack/pull/8603#issuecomment-2064670067

   > To be honest, I think the old error message makes more sense for root admin
   
   @weizhouapache,
   
   One of the major issues with the old exception message is its lack of 
clarity. Even for root admins, it would be difficult to discern what action 
needs to be taken.
   
   The new exception is more generic compared to the old one, as the intention 
is to give no environment information. To give any direction to operators, this 
PR adds a new log that is more objective, indicating to the operator where and 
what the problem is. IMO, the new message can also help prevent operators from 
making the same mistake again, as they will now know that `endpoint.url` can't 
be blank or `localhost`. The old message states `endpoint.url has to be set`, 
but if the `endpoint.url` is `localhost`, then it is already set, albeit with 
an invalid value, and the old message would not make sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to