JoaoJandre commented on code in PR #8742:
URL: https://github.com/apache/cloudstack/pull/8742#discussion_r1572644711
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3064,33 +3060,31 @@ protected void
checkL2OfferingServices(NetworkOfferingVO ntwkOff) {
public boolean shutdownNetwork(final long networkId, final
ReservationContext context, final boolean cleanupElements) {
NetworkVO network = _networksDao.findById(networkId);
if (network.getState() == Network.State.Allocated) {
- logger.debug("Network is already shutdown: " + network);
+ logger.debug("Network is already shutdown: {}", network);
return true;
}
if (network.getState() != Network.State.Implemented &&
network.getState() != Network.State.Shutdown) {
- logger.debug("Network is not implemented: " + network);
+ logger.debug("Network is not implemented: {}", network);
return false;
}
try {
//do global lock for the network
network = _networksDao.acquireInLockTable(networkId,
NetworkLockTimeout.value());
if (network == null) {
- logger.warn("Unable to acquire lock for the network " +
network + " as a part of network shutdown");
+ logger.warn("Unable to acquire lock for the network {} as a
part of network shutdown", network);
return false;
}
- if (logger.isDebugEnabled()) {
- logger.debug("Lock is acquired for network " + network + " as
a part of network shutdown");
- }
+ logger.debug("Lock is acquired for network " + network + " as a
part of network shutdown");
Review Comment:
String concatenation
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3880,51 +3874,51 @@ private boolean cleanupNetworkResources(final long
networkId, final Account call
//remove all PF/Static Nat rules for the network
try {
if (_rulesMgr.revokeAllPFStaticNatRulesForNetwork(networkId,
callerUserId, caller)) {
- logger.debug("Successfully cleaned up portForwarding/staticNat
rules for network id=" + networkId);
+ logger.debug("Successfully cleaned up portForwarding/staticNat
rules for network id={}", networkId);
} else {
success = false;
- logger.warn("Failed to release portForwarding/StaticNat rules
as a part of network id=" + networkId + " cleanup");
+ logger.warn("Failed to release portForwarding/StaticNat rules
as a part of network id={} cleanup", networkId);
}
} catch (final ResourceUnavailableException ex) {
success = false;
// shouldn't even come here as network is being cleaned up after
all network elements are shutdown
- logger.warn("Failed to release portForwarding/StaticNat rules as a
part of network id=" + networkId + " cleanup due to resourceUnavailable ", ex);
+ logger.warn("Failed to release portForwarding/StaticNat rules as a
part of network id={} cleanup due to resourceUnavailable" + networkId, ex);
Review Comment:
Wrong syntax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
