DaanHoogland commented on code in PR #8924:
URL: https://github.com/apache/cloudstack/pull/8924#discussion_r1577387114
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -104,20 +105,20 @@ public void onConnect(final Session session) throws
IOException, InterruptedExce
try {
port = Integer.parseInt(portStr);
} catch (NumberFormatException e) {
- logger.error("Invalid port value in query string: {}. Expected a
number.", portStr, e);
+ logger.error(String.format("Invalid port value in query string:
%s. Expected a number.", portStr), e);
throw new IllegalArgumentException(e);
}
if (ajaxSessionIdStr != null) {
try {
ajaxSessionId = Long.parseLong(ajaxSessionIdStr);
} catch (NumberFormatException e) {
- logger.error("Invalid ajaxSessionId (sess) value in query
string: {}. Expected a number.", ajaxSessionIdStr, e);
+ logger.error(String.format("Invalid ajaxSessionId (sess) value
in query string: %s. Expected a number.", ajaxSessionIdStr), e);
Review Comment:
can you undo this change
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java:
##########
@@ -79,15 +79,15 @@ public void connectTo(String host, int port, String path,
String session, boolea
port = 80;
}
- logger.info("Connecting to VNC server {}:{} ...", host, port);
+ logger.info(String.format("Connecting to VNC server %s:%s ...", host,
port));
RawHTTP tunnel = new RawHTTP("CONNECT", host, port, path, session,
useSSL);
socket = tunnel.connect();
setTunnelSocketStreams();
}
public void connectTo(String host, int port) {
// Connect to server
- logger.info("Connecting to VNC server {}:{} ...", host, port);
+ logger.info(String.format("Connecting to VNC server %s:%s ...", host,
port));
Review Comment:
can you undo this change?
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java:
##########
@@ -79,15 +79,15 @@ public void connectTo(String host, int port, String path,
String session, boolea
port = 80;
}
- logger.info("Connecting to VNC server {}:{} ...", host, port);
+ logger.info(String.format("Connecting to VNC server %s:%s ...", host,
port));
Review Comment:
can you undo this change?
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -104,20 +105,20 @@ public void onConnect(final Session session) throws
IOException, InterruptedExce
try {
port = Integer.parseInt(portStr);
} catch (NumberFormatException e) {
- logger.error("Invalid port value in query string: {}. Expected a
number.", portStr, e);
+ logger.error(String.format("Invalid port value in query string:
%s. Expected a number.", portStr), e);
Review Comment:
can you undo this change?
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -180,7 +182,7 @@ public void onClose(Session session, int statusCode, String
reason) throws IOExc
@OnWebSocketFrame
public void onFrame(Frame f) throws IOException {
- logger.trace("Sending client frame of {} bytes.",
f.getPayloadLength());
+ logger.trace(String.format("Sending client frame of %s bytes.",
f.getPayloadLength()));
Review Comment:
can you undo this change?
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -147,7 +150,7 @@ public void onConnect(final Session session) throws
IOException, InterruptedExce
viewer = ConsoleProxy.getNoVncViewer(param, ajaxSessionIdStr,
session);
logger.debug("Viewer has been created successfully.");
} catch (Exception e) {
- logger.error("Failed to create viewer due to {}", e.getMessage(),
e);
+ logger.error(String.format("Failed to create viewer due to %s",
e.getMessage()), e);
Review Comment:
can you undo this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
