weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124336886
> @weizhouapache I see some other usages of `Nic.getinstanceId()` in code, do we need to fix/address them? [nic-instanceid.diff.txt](https://github.com/apache/cloudstack/files/15400616/nic-instanceid.diff.txt) thanks @shwstppr it looks like we need a lot of other changes due to the integer-> Integer change probably we can just ignore the error by ``` try { nic.getInstanceId(); } catch (NullPointerException ex) { return; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
