shwstppr commented on code in PR #9070:
URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1616889053
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -1270,29 +1280,64 @@ private SecurityGroup
getOrCreateSecurityGroupForAccount(Account owner) {
return securityGroup;
}
+ @Override
+ @ActionEvent(eventType =
KubernetesClusterEventTypes.EVENT_KUBERNETES_CLUSTER_CREATE,
+ eventDescription = "creating Kubernetes cluster", async = true)
Review Comment:
@vishesh92 this is not needed as it is done deliberately to allow publishing
`Completed` state event for `EVENT_KUBERNETES_CLUSTER_CREATE`. Argument passed
for the method here is also `CreateKubernetesClusterCmd` so it will be used
only when the cluster is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
