vishesh92 opened a new pull request, #9178:
URL: https://github.com/apache/cloudstack/pull/9178
### Description
During live migration of a VM from between hosts having different cgroup
versions (cgroupv2 & cgroup), overcommit ratio is ignored.
This PR fixes the above issue.
<!--- Describe your changes in DETAIL - And how has behaviour functionally
changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to
reproduce. -->
#### Steps to reproduce
1. Set overcommit ratio to 2 for the cluster
2. Launch a VM
3. Check value of shares on the host
```bash
$ virsh dumpxml --domain i-2-9-VM | grep shares
<shares>500</shares>
```
4. Live migrate the VM to another host which has a different cgroup than the
existing host of the VM.
5. Live migrate the VM back to the original host. And check the shares again.
```bash
$ virsh dumpxml --domain i-2-9-VM | grep shares
<shares>1000</shares>
```
6. Stopping and starting the VM on the same host will reset the value back
to `500`.
This happens only when cgroup is different on the destination hosts during
live migration. Possibly introduced in #8252 .
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be
closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!---
*******************************************************************************
-->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE
DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!---
*******************************************************************************
-->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Not able to reproduce the issue after the patch.
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to
-->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
