rohityadavcloud commented on code in PR #9219:
URL: https://github.com/apache/cloudstack/pull/9219#discussion_r1634665573


##########
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java:
##########
@@ -238,9 +245,8 @@ public String authenticate(final String command, final 
Map<String, Object[]> par
                                 params, responseType));
                     }
                 }
-                if (username == null) {

Review Comment:
   FYI - username is always declared as null above, so no point in checking 
that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to