shwstppr commented on code in PR #9212:
URL: https://github.com/apache/cloudstack/pull/9212#discussion_r1634657512
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java:
##########
@@ -175,6 +178,12 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
s_logger.debug(String.format("Replaced disk mount point
[%s] with [%s] in VM [%s] XML configuration. New XML configuration is [%s].",
oldIsoVolumePath, newIsoVolumePath, vmName, xmlDesc));
}
}
+
+ // Replace CDROM ISO path
+ String oldCdromIsoPath = getOldVolumePathForCdrom(disks, vmName);
+ String newCdromIsoPath =
getNewVolumePathForCdrom(libvirtComputingResource, conn, to);
+ xmlDesc = replaceCdromIsoPath(xmlDesc, vmName, oldCdromIsoPath,
newCdromIsoPath);
Review Comment:
Do we need any check if both old and new ISO path are same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
