Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

[via GitHub]

DaanHoogland commented on code in PR #9207:
URL: https://github.com/apache/cloudstack/pull/9207#discussion_r1635971625


##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##########
@@ -599,13 +598,13 @@ public List<Pair<String, Long>> 
getSecondaryStorageStoresUrlAndIdList(long dcId)
         }
 
         if (urlIdList.isEmpty()) {
-            // we are using non-NFS image store, then use cache storage instead
-            s_logger.info("Secondary storage is not NFS, we need to use 
staging storage");
+            // image stores doesn't have enough capacity or we are using 
non-NFS image store, then use cache storage instead

Review Comment:
   ```suggestion
   ```
   



##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##########
@@ -572,18 +571,18 @@ public Pair<String, Long> 
getSecondaryStorageStoreUrlAndId(long dcId) {
         }
 
         if (secUrl == null) {
-            // we are using non-NFS image store, then use cache storage instead
-            s_logger.info("Secondary storage is not NFS, we need to use 
staging storage");
+            // image stores doesn't have enough capacity or we are using 
non-NFS image store, then use cache storage instead

Review Comment:
   ```suggestion
   ```
   
   this is already in the log statement, i think we can delete the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org