sureshanaparti commented on code in PR #9209:
URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1636140359


##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##########
@@ -2794,6 +2799,16 @@ public void checkAndRepairVolumeBasedOnConfig(DataObject 
dataObject, Host host)
         }
     }
 
+    @Override
+    public void validateChangeDiskOfferingEncryptionType(long 
existingDiskOfferingId, long newDiskOfferingId) {
+        DiskOfferingVO existingDiskOffering = 
diskOfferingDao.findById(existingDiskOfferingId);
+        DiskOfferingVO newDiskOffering = 
diskOfferingDao.findById(newDiskOfferingId);

Review Comment:
   in any case, new or old offering is removed, checked before this call?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to