vishesh92 commented on code in PR #8508:
URL: https://github.com/apache/cloudstack/pull/8508#discussion_r1636366530
##########
test/integration/smoke/test_cluster_drs.py:
##########
@@ -256,12 +294,15 @@ def test_02_balanced_drs_algorithm(self):
migration["virtualmachineid"]: migration["destinationhostid"] for
migration in migrations
}
- self.assertEqual(len(vm_to_dest_host_map), 1, msg="DRS plan should
have 1 migrations")
+ # this is one if no svm is considered to be migrated, it might be
higher
+ self.assertTrue(len(vm_to_dest_host_map) >= 1, msg="DRS plan should
have at least 1 migrations")
executed_plan = self.cluster.executeDrsPlan(self.apiclient,
vm_to_dest_host_map)
self.wait_for_plan_completion(executed_plan)
vm_1_host_id = self.get_vm_host_id(self.virtual_machine_1.id)
vm_2_host_id = self.get_vm_host_id(self.virtual_machine_2.id)
- self.assertNotEqual(vm_1_host_id, vm_2_host_id, msg="Both VMs should
be on different hosts")
+ self.assertTrue(
+ vm_1_host_id != self.virtual_machine_1.hostid or vm_2_host_id !=
self.virtual_machine_1.hostid,
Review Comment:
```suggestion
vm_1_host_id != self.virtual_machine_1.hostid or vm_2_host_id !=
self.virtual_machine_2.hostid,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
