JoaoJandre commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2163215354
> > @vishesh92 @DaanHoogland I agree that if we are to have a configuration for each table it would be too much. However, the configuration that @vishesh92 proposed to use (`detail.batch.query.size`) is meant for listing, not removing; thus, I would not use it for the purpose of this PR. > > As this is a broader discussion, I think that we should move this discussion somewhere else to agree on which configurations should exist, then when/if something is decided, we can create a PR to normalize all the required tables. I feel like this is out of scope for this PR, as we would have to change a lot of code that is not related to the `vm_stats` table and metrics deletion, which is the focus for this PR. > > @JoaoJandre The PR looks good. Can we rename the global setting to something more generic like `delete.batch.query.size` for deletions across table? If not, what is our way forward when we have a lot of these? > > Also the Build Github Action is failing due to test failures. Please check. As I said on my previous message, this PR is focusing only on the `vm_stats` table, as it is the one that caused issues. To create a generic configuration is out of scope for this PR. If we face a situation where we need to create lots of these configurations, then we can discuss a generic configuration, but for now, this is the only one that exists. Also, the tests should be fixed now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
