weizhouapache commented on code in PR #9223:
URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636927477
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -378,7 +378,7 @@ public VMTemplateVO getKubernetesServiceTemplate(DataCenter
dataCenter, Hypervis
}
protected void validateIsolatedNetworkIpRules(long ipId,
FirewallRule.Purpose purpose, Network network, int clusterTotalNodeCount) {
- List<FirewallRuleVO> rules =
firewallRulesDao.listByIpAndPurposeAndNotRevoked(ipId, purpose);
+ List<FirewallRuleVO> rules =
firewallRulesDao.listByIpPurposeProtocolAndNotRevoked(ipId, purpose, "tcp");
Review Comment:
'tcp' can be replaced with NetUtils.TCP_PROTO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
