JoaoJandre commented on PR #8909: URL: https://github.com/apache/cloudstack/pull/8909#issuecomment-2165430245
> Thanks @JoaoJandre, we have the option when changing disk offering to migrate to another storage if required, why not fix it there instead?  > > I think it's more lean approach to execute this operation since in the case you've described you might end up with volume on shared storage while having assigned offering of local storage and vice versa. Currently migrating cross different types of storage seems not working ( returns 'Index 0 out of bounds for length 0' ), would you consider moving the fix there? Hey @borisstoyanov, I think you misunderstood the PR. The issue is not with the disk offering, but with a validation that makes no sense: the destination host does not need to have access to the original storage, regardless of the disk offering. This PR fixes the current validation to reflect that. About ending up with a disk offering in a storage with different type, this is current behavior, as introduced in #2425. It is assumed that when the ROOT admin migrates the volume somewhere, they know what they are doing. Same applies to migrating VMs to hosts that do not have a certain tag, the root admin has this power. I didn't understand your last point, are you saying that this PR broke migration across different types of storage, or that this is a current issue? if so, could you give me the link to the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
