vishesh92 commented on code in PR #9330:
URL: https://github.com/apache/cloudstack/pull/9330#discussion_r1664187904
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/BasePrimaryDataStoreLifeCycleImpl.java:
##########
@@ -39,9 +38,12 @@
import com.cloud.storage.StoragePoolHostVO;
import com.cloud.storage.dao.StoragePoolHostDao;
import com.cloud.utils.Pair;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class BasePrimaryDataStoreLifeCycleImpl {
- private static final Logger s_logger =
Logger.getLogger(BasePrimaryDataStoreLifeCycleImpl.class);
+ private static final Logger logger =
LogManager.getLogger(BasePrimaryDataStoreLifeCycleImpl.class);
Review Comment:
Isn't it better to have different loggers for inherited classes to identify
the source class of a log line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
