vishesh92 commented on code in PR #9329:
URL: https://github.com/apache/cloudstack/pull/9329#discussion_r1672277781
##########
engine/storage/configdrive/src/main/java/org/apache/cloudstack/storage/configdrive/ConfigDriveBuilder.java:
##########
@@ -250,6 +298,124 @@ static JsonObject
createJsonObjectWithVmData(List<String[]> vmData, String tempD
return metaData;
}
+ /**
+ * Creates the {@link JsonObject} using @param nic's metadata. We expect
the JSONObject to have the following entries:
+ * <ul>
+ * <li> links </li>
+ * <li> networks </li>
+ * <li> services </li>
+ * </ul>
+ */
+ static JsonObject getNetworkDataJsonObjectForNic(NicProfile nic,
List<Network.Service> supportedServices) {
+ JsonObject networkData = new JsonObject();
+
+ if (supportedServices.contains(Network.Service.Dhcp)) {
Review Comment:
In case of multiple networks, we will need to pass the configuration of
other networks (non-configdrive) here. Otherwise nic won't be setup on the VM
for non configdrive networks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
