nvazquez commented on code in PR #8906:
URL: https://github.com/apache/cloudstack/pull/8906#discussion_r1717186043
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterStartWorker.java:
##########
@@ -241,6 +248,11 @@ private String
getKubernetesAdditionalControlNodeConfig(final String joinIp, fin
final String sshPubKey = "{{ k8s.ssh.pub.key }}";
final String clusterHACertificateKey = "{{
k8s_control_node.cluster.ha.certificate.key }}";
final String ejectIsoKey = "{{ k8s.eject.iso }}";
+ final String installWaitTime = "{{ k8s.install.wait.time }}";
Review Comment:
Same for all these CKS logic using the settings values
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterService.java:
##########
@@ -92,6 +92,30 @@ public interface KubernetesClusterService extends
PluggableService, Configurable
true,
ConfigKey.Scope.Account,
KubernetesServiceEnabled.key());
+ static final ConfigKey<Long> KubernetesControlNodeInstallAttemptWait = new
ConfigKey<Long>("Advanced", Long.class,
Review Comment:
I think these settings shouldn't be part of this PR but for #9102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
