sureshanaparti commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1719313768
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
##########
@@ -1849,6 +1858,488 @@ public Answer createSnapshot(final CreateObjectCommand
cmd) {
}
}
+ private SnapshotObjectTO createSnapshotToAndUpdatePathAndSize(String path,
String fullPath) {
+ final File snapFile = new File(fullPath);
+ long size = 0;
+
+ if (snapFile.exists()) {
+ size = snapFile.length();
+ }
Review Comment:
if snapshot file doesn't exists, is it Ok to throw error here, instead of
returning the path with size 0? or anywhere else it is checked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
