shwstppr commented on code in PR #9569:
URL: https://github.com/apache/cloudstack/pull/9569#discussion_r1728412596
##########
api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java:
##########
@@ -92,6 +92,10 @@ public class CapabilitiesResponse extends BaseResponse {
@Param(description = "true if users can see all accounts within the same
domain, false otherwise")
private boolean allowUserViewAllDomainAccounts;
+ @SerializedName("allowuserforcestopvm")
Review Comment:
Better to define it in ApiConstants
##########
api/src/main/java/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java:
##########
@@ -55,6 +55,7 @@ public void execute() {
response.setAllowUserExpungeRecoverVM((Boolean)capabilities.get("allowUserExpungeRecoverVM"));
response.setAllowUserExpungeRecoverVolume((Boolean)capabilities.get("allowUserExpungeRecoverVolume"));
response.setAllowUserViewAllDomainAccounts((Boolean)capabilities.get("allowUserViewAllDomainAccounts"));
+
response.setAllowUserForceStopVM((Boolean)capabilities.get("allowUserForceStopVM"));
Review Comment:
Use key from ApiConstants?
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -4486,6 +4487,7 @@ public Map<String, Object> listCapabilities(final
ListCapabilitiesCmd cmd) {
capabilities.put("allowUserExpungeRecoverVM",
allowUserExpungeRecoverVM);
capabilities.put("allowUserExpungeRecoverVolume",
allowUserExpungeRecoverVolume);
capabilities.put("allowUserViewAllDomainAccounts",
allowUserViewAllDomainAccounts);
+ capabilities.put("allowUserForceStopVM", allowUserForceStopVM);
Review Comment:
same as previous comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
