slavkap commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1728451428
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##########
@@ -504,10 +504,10 @@ public Void
deleteVolumeCallback(AsyncCallbackDispatcher<VolumeServiceImpl, Comm
if (!supportsStorageSystemSnapshots) {
_snapshotStoreDao.remove(snapStoreVo.getId());
}
- } else {
- if
(!StoragePoolType.StorPool.equals(storagePoolVO.getPoolType())) {
- _snapshotStoreDao.remove(snapStoreVo.getId());
- }
+ } else if
(HypervisorType.KVM.equals(vo.getHypervisorType())) {
Review Comment:
@JoaoJandre, right now, I don't think there is a need. It will require many
changes in the plugin and the CloudStack core to work like now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
