DaanHoogland commented on code in PR #9573:
URL: https://github.com/apache/cloudstack/pull/9573#discussion_r1730822508
##########
framework/db/src/main/java/com/cloud/utils/db/Filter.java:
##########
@@ -69,7 +75,7 @@ public Filter(Filter that) {
that._limit = null;
}
- public void addOrderBy(Class<?> clazz, String field, boolean ascending) {
+ public void addOrderBy(Class<?> clazz, String field, boolean ascending,
String tableAlias) {
Review Comment:
good call @vishesh92 , makes this change a lot smaller and the rest of the
code cleaner (less <null>)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
