weizhouapache commented on code in PR #9585:
URL: https://github.com/apache/cloudstack/pull/9585#discussion_r1730859388
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -3065,8 +3065,12 @@ public Network updateGuestNetwork(final UpdateNetworkCmd
cmd) {
}
// network offering and domain suffix can be updated for Isolated
networks only in 3.0
- if ((networkOfferingId != null || domainSuffix != null) &&
network.getGuestType() != GuestType.Isolated) {
- throw new InvalidParameterValueException("NetworkOffering and
domain suffix upgrade can be performed for Isolated networks only");
+ if (networkOfferingId != null && network.getGuestType() !=
GuestType.Isolated) {
+ throw new InvalidParameterValueException("NetworkOffering update
can be performed for Isolated networks only.");
+ }
+ // network offering and domain suffix can be updated for Isolated
networks only in 3.0
+ if (domainSuffix != null && ! Arrays.asList(GuestType.Isolated,
GuestType.Shared).contains(network.getGuestType())) {
Review Comment:
if domain suffix is changed, will VR be restarted to reflect the changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
