DaanHoogland commented on code in PR #9552:
URL: https://github.com/apache/cloudstack/pull/9552#discussion_r1731016407
##########
systemvm/debian/opt/cloud/bin/cs/CsAddress.py:
##########
@@ -693,11 +693,8 @@ def post_config_change(self, method):
vpccidr = cmdline.get_vpccidr()
self.fw.append(
["filter", 3, "-A FORWARD -s %s ! -d %s -j ACCEPT" %
(vpccidr, vpccidr)])
- self.fw.append(
- ["nat", "", "-A POSTROUTING -j SNAT -o %s --to-source %s"
% (self.dev, self.address['public_ip'])])
- elif cmdline.get_source_nat_ip() and not self.is_private_gateway():
- self.fw.append(
- ["nat", "", "-A POSTROUTING -j SNAT -o %s --to-source %s"
% (self.dev, cmdline.get_source_nat_ip())])
+ self.fw.append(
Review Comment:
I am not sure I understand the question. I checked this in a lab env and the
resulting nat table was exactly as described in the issue, with only the last
line being different. Ar you considdering another configuration here
@weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
