nvazquez commented on code in PR #8906:
URL: https://github.com/apache/cloudstack/pull/8906#discussion_r1731922292
##########
engine/components-api/src/main/java/com/cloud/network/vpc/VpcManager.java:
##########
@@ -122,7 +122,7 @@ public interface VpcManager {
* @throws InsufficientAddressCapacityException
* @throws ConcurrentOperationException
*/
- PublicIp assignSourceNatIpAddressToVpc(Account owner, Vpc vpc) throws
InsufficientAddressCapacityException, ConcurrentOperationException;
+ PublicIp assignSourceNatIpAddressToVpc(Account owner, Vpc vpc, Long podId,
boolean forNsx) throws InsufficientAddressCapacityException,
ConcurrentOperationException;
Review Comment:
@DaanHoogland thanks I've refactored it to remove the boolean from the
service interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
