DaanHoogland commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2320968034
> Thanks @shwstppr @DaanHoogland for the review, let me try & address as much as I could. > > @DaanHoogland to answer your comments; > > 1. yes, this is mostly for KVM; however, we think this may be in future expanded to other hypervisors; as most hypervisors support NFS (at least) among the supported NAS types; the method to take/restore backup could use full VM snapshots of non-KVM hypervisors. ok, great. > 2. yes, backup repository concept for now is specific to only this plugin - however, if the scope expands to a general purpose B&R plugin, then this becomes non-specific to the plugin. Also I think the networkers & veeam plugins have some concept of backup repository or backup storage which can reuse this concept. That said, I'm happy to move the dao/vo logic to the plugin if you really insist (and refactor in future). If it is that's fine. It was just not that obvious to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
