JoaoJandre commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1747114509
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1502,6 +1579,29 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume)
throws ResourceAllocationExc
return snapshot;
}
+ private void postSnapshotDirectlyToSecondary(SnapshotInfo snapshot,
SnapshotInfo snapshotOnPrimary, Long snapshotId) {
+ logger.debug("{} was directly copied to secondary storage because the
hypervisor is KVM, the primary storage is file-based and the [{}]
configuration" +
+ " is set to true.", snapshot.getSnapshotVO().toString(),
SnapshotInfo.BackupSnapshotAfterTakingSnapshot);
+
+ SnapshotDataStoreVO snapshotStore =
_snapshotStoreDao.findBySnapshotIdAndDataStoreRoleAndState(snapshotId,
DataStoreRole.Image, ObjectInDataStoreStateMachine.State.Allocated);
+
+ snapshotStore.setInstallPath(snapshotOnPrimary.getPath());
Review Comment:
I'm sorry, but I didn't understand this comment, are you getting a NPE here?
If so, when does this happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
