weizhouapache opened a new pull request, #9698: URL: https://github.com/apache/cloudstack/pull/9698
### Description This PR fixes an issue reproduced by steps below - create a LB with algorithm=Source (not `source`) - add a vm to the lb - check cloudstack VR, haproxy fails ``` Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE] (2042) : haproxy version is 2.6.12-1+deb12u1 Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE] (2042) : path to executable is /usr/sbin/haproxy Sep 18 06:52:12 r-721-VM haproxy[2042]: [WARNING] (2042) : config : 'stats' statement ignored for proxy 'cloud-default' as it requires HTTP mode. Sep 18 06:52:12 r-721-VM haproxy[2042]: [WARNING] (2042) : config : 'option forwardfor' ignored for proxy 'cloud-default' as it requires HTTP mode. Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE] (2042) : New worker (2069) forked Sep 18 06:52:12 r-721-VM haproxy[2042]: [NOTICE] (2042) : Loading success. Sep 18 06:52:12 r-721-VM systemd[1]: Started haproxy.service - HAProxy Load Balancer. Sep 18 07:32:46 r-721-VM systemd[1]: Reloading haproxy.service - HAProxy Load Balancer... Sep 18 07:32:46 r-721-VM systemd[1]: haproxy.service: Control process exited, code=exited, status=1/FAILURE Sep 18 07:32:46 r-721-VM systemd[1]: Reload failed for haproxy.service - HAProxy Load Balancer. ``` - the issue can be manually fixed by ``` # root@r-721-VM:~# sed -i "s/balance Source/balance source/g" /etc/haproxy/haproxy.cfg # systemctl reload haproxy ``` <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
