rp- commented on code in PR #9792:
URL: https://github.com/apache/cloudstack/pull/9792#discussion_r1799628771


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2982,6 +2982,13 @@ public String getVolumePath(final Connect conn, final 
DiskTO volume, boolean dis
         return dataPath;
     }
 
+    public static boolean useBLOCKDiskType(KVMPhysicalDisk physicalDisk) {
+        return physicalDisk != null &&
+                physicalDisk.getPool().getType() == StoragePoolType.Linstor &&

Review Comment:
   @slavkap This might also interesting for you, as I think you also provide 
block devices to libvirt, but since QEMU 6.0. Qemu doesn't allow block devices 
anymore for the FILE driver.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to