weizhouapache commented on code in PR #9822:
URL: https://github.com/apache/cloudstack/pull/9822#discussion_r1819290488
##########
systemvm/debian/opt/cloud/bin/cs/CsFile.py:
##########
@@ -175,6 +175,6 @@ def deleteLine(self, search):
self.new_config = list(temp_config)
def compare(self, o):
- result = (isinstance(o, self.__class__) and set(self.config) ==
set(o.config))
+ result = (isinstance(o, self.__class__) and self.config == o.config)
Review Comment:
yes, we should compare lines by lines.
the method is being used to compare the configurations for
- haproxy
- conntrackd
- radvd
for all 3, I think the order of configurations in the files matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
