shwstppr commented on code in PR #9840:
URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828949324
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java:
##########
@@ -142,7 +142,10 @@ protected void updateDomainResponse(List<DomainResponse>
response) {
if (CollectionUtils.isEmpty(response)) {
return;
}
-
_resourceLimitService.updateTaggedResourceLimitsAndCountsForDomains(response,
getTag());
+ EnumSet<DomainDetails> details = getDetails();
+ if (details.contains(DomainDetails.all) ||
details.contains(DomainDetails.resource)) {
+
_resourceLimitService.updateTaggedResourceLimitsAndCountsForDomains(response,
getTag());
Review Comment:
This PR is intended for 4.20.1. I can create a separate PR for these changes
but not sure if we can get it in 4.20.0 release with RC/release work already
underway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
