weizhouapache commented on code in PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#discussion_r1871154421
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -247,8 +247,8 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv
/**
* Machine type.
*/
- private static final String PC = "pc";
- private static final String VIRT = "virt";
+ private static final String PC =
("s390x".equals(System.getProperty("os.arch"))) ? "s390-ccw-virtio" : "pc";
Review Comment:
can define a constant for `s390-ccw-virtio`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
