Pearl1594 commented on code in PR #10174:
URL: https://github.com/apache/cloudstack/pull/10174#discussion_r1908704590
##########
utils/src/main/java/com/cloud/utils/net/NetUtils.java:
##########
@@ -574,7 +574,7 @@ public static boolean isValidIp4Cidr(final String cidr) {
final String[] cidrPair = cidr.split("\\/");
if (cidrPair.length != 2) {
- return false;
+ return isValidIp4(cidr); // we consider an ip4v address as a valid
/32 cidr
Review Comment:
While this is right, this method is called at a lot of places and I worry if
at the other places they really require a CIDR. So, I would localize the change
to `getCleanIp4Cidr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
