harikrishna-patnala opened a new pull request, #10231: URL: https://github.com/apache/cloudstack/pull/10231
### Description This PR addresses the issues raised in https://github.com/apache/cloudstack/issues/9820 Case 1: Delete local storage pool entry even if local storage addition fails. Case 2: Delete local.storage.uuid and path entries in agent.properties when local storage is deleted from management server. If not deleted then on every agent restart it will be added again in the management server. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### How Has This Been Tested? Case 1: 1. Create local storage with invalid path. 2. Local storage addition fails. 3. Previously there is an active local storage entry even it failed to add, now there won't be any entry. Case 2: 1. Add multiple local storages as in steps mentioned here https://docs.cloudstack.apache.org/en/4.19.0.0/adminguide/storage.html#manually-adding-local-storage-pool 2. Delete one local storage from management server 3. Previously that local storage entry existed in agent.properties and on restart of the agent the same local storage gets added again. Now the entry is deleted in agent.properties and on restart of agent did not added the local storage again. <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
