rp- commented on code in PR #10132:
URL: https://github.com/apache/cloudstack/pull/10132#discussion_r1931654204
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##########
@@ -923,6 +924,7 @@ private HostVO
getHostOnWhichToExecuteMigrationCommand(VolumeInfo srcVolumeInfo,
HostVO hostVO;
// if either source or destination is a HOST-scoped storage pool, the
migration MUST be performed on that host
+
Review Comment:
I would cleanup all those new line introductions, if they don't have any
purpose,
as they just make the diff/review larger and leave useless traces in `git
blame`
##########
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java:
##########
@@ -1568,6 +1580,8 @@ else if (volumeInfo.getFormat() == ImageFormat.OVA) {
}
}
+
+
Review Comment:
I would cleanup all those new line introductions, if they don't have any
purpose,
as they just make the diff/review larger and leave useless traces in `git
blame`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
