hsato03 commented on code in PR #10282:
URL: https://github.com/apache/cloudstack/pull/10282#discussion_r1956702841
##########
plugins/storage/volume/adaptive/src/main/java/org/apache/cloudstack/storage/datastore/adapter/ProviderAdapterDiskOffering.java:
##########
@@ -166,7 +166,7 @@ enum State {
}
enum DiskCacheMode {
- NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+ HYPERVISOR_DEFAULT("hypervisor_default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
Regarding the `DiskOffering.DiskCacheMode` enum, it represents the value of
the users input in an API call. On the other hand, the
`LibvirtVMDef.DiskCacheMode` enum represents the value that will be used in the
VM XML. In this case, the value of the `HYPERVISOR_DEFAULT` field is slightly
different between these enums.
Concerning the `ProviderAdapterDiskOffering.DiskCacheMode`, it could be
refactored to use the `DiskOffering.DiskCacheMode` enum, but I think this can
be done in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
