DaanHoogland commented on code in PR #9969:
URL: https://github.com/apache/cloudstack/pull/9969#discussion_r1957130745
##########
setup/bindir/cloud-setup-databases.in:
##########
@@ -229,6 +229,10 @@ for full help
"GRANT ALL ON cloud_usage.* to cloud@`%`;",
"GRANT process ON *.* TO cloud@`localhost`;",
"GRANT process ON *.* TO cloud@`%`;",
+ "IF foo > 0 THEN",
Review Comment:
wouw, this is unreadable code (not your fault per sé)
so as I read this, this means that the lines
```
"IF foo > 0 THEN"
```
,
```
"DROP USER 'cloud'@'localhost' ;"
```
and
```
"END IF;"
```
are being skipped.
That does not seem to be the intention of the code. Should it just
(conditionally) add the middle line? Or does it somehow do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
