winterhazel commented on code in PR #10457:
URL: https://github.com/apache/cloudstack/pull/10457#discussion_r1968519491
##########
api/src/main/java/org/apache/cloudstack/backup/BackupProvider.java:
##########
@@ -116,4 +115,11 @@ public interface BackupProvider {
* @param metric
*/
Backup createNewBackupEntryForRestorePoint(Backup.RestorePoint
restorePoint, VirtualMachine vm, Backup.Metric metric);
+
+ /**
+ * This method should reconcile and create backup entries for any backups
created out-of-band
+ * @param vm
+ * @param metric
+ */
+ void syncBackups(VirtualMachine vm, Backup.Metric metric);
Review Comment:
This method was intentionally removed in #10017, it should not be restored.
The issue arises from the incompatibility between #10017 and #9898. To fix
it, we need to move the changes from #9898 in
`org.apache.cloudstack.backup.VeeamBackupProvider#syncBackups` to
`org.apache.cloudstack.backup.VeeamBackupProvider#createNewBackupEntryForRestorePoint`
and remove `org.apache.cloudstack.backup.VeeamBackupProvider#syncBackups`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
