abh1sar commented on code in PR #10457:
URL: https://github.com/apache/cloudstack/pull/10457#discussion_r1969208776
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##########
@@ -414,6 +407,11 @@ public boolean willDeleteBackupsOnOfferingRemoval() {
return false;
}
+ @Override
+ public void syncBackups(VirtualMachine vm, Backup.Metric metric) {
Review Comment:
syncBackups has been moved to BackupManagerImpl. Need to remove syncBackups
from all providers.
##########
plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java:
##########
@@ -344,6 +352,23 @@ public List<Backup.RestorePoint>
listRestorePoints(VirtualMachine vm) {
return getClient(vm.getDataCenterId()).listRestorePoints(backupName,
vm.getInstanceName());
}
+ private Backup
checkAndUpdateIfBackupEntryExistsForRestorePoint(List<Backup> backupsInDb,
Backup.RestorePoint restorePoint, Backup.Metric metric) {
Review Comment:
this method has also been moved along with syncBackups to BackupManagerImpl.
can be removed from here
##########
plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java:
##########
@@ -328,54 +328,12 @@ public Map<VirtualMachine, Backup.Metric>
getBackupMetrics(final Long zoneId, fi
@Override
Review Comment:
Please restore the code in createNewBackupEntryForRestorePoint and
listRestorePoints, and delete code from syncBackups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
